Skip to content
This repository has been archived by the owner on Jul 31, 2018. It is now read-only.

Chore/dry up action names #46

Closed
wants to merge 2 commits into from

Conversation

thebigredgeek
Copy link

@tj thoughts here? Got started building something and saw this. I figured it was kind of a no brainer PR

@tj
Copy link
Owner

tj commented Jan 26, 2016

I like the direction of #35 but it just needs a better name for the dir or to remove the nesting I think. I think constants are kind of unnecessary in js though, I can say that I've literally never "accidentally" re-assigned one. I think if we're going to add constants instead of just using strings they should be in the same file so it's not too annoying to reference, since you can easily import the wrong name and end up with it just giving you undefined

@thebigredgeek
Copy link
Author

Yeah I think that would also work too. Having it all in a single file definitely has it's own benefits. For a boilerplate that probably makes sense anyway. You only break stuff out into multiple files if the project gets HUGE. I'll close this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants